Skip to content

AVRO-4191 - include tests on JDK 25#3685

Open
apupier wants to merge 10 commits intoapache:mainfrom
apupier:4191-testWithJDK25
Open

AVRO-4191 - include tests on JDK 25#3685
apupier wants to merge 10 commits intoapache:mainfrom
apupier:4191-testWithJDK25

Conversation

@apupier
Copy link

@apupier apupier commented Mar 9, 2026

What is the purpose of the change

(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)

Verifying this change

(Please pick one of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Extended interop tests to verify consistent valid schema names between SDKs
  • Added test that validates that Java throws an AvroRuntimeException on invalid binary data
  • Manually verified the change by building the website and checking the new redirect

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@apupier
AVRO-4191 - include tests on JDK 25
31f2de5 
Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@github-actions github-actions bot added Java Pull Requests for Java binding build labels Mar 9, 2026
@martin-g martin-g closed this Mar 9, 2026
@martin-g martin-g reopened this Mar 9, 2026
@martin-g
Copy link
Member

martin-g commented Mar 9, 2026

For some reason the Java SDK build and tests are not triggered ...

martin-g added 5 commits March 9, 2026 13:34
@martin-g
Trigger the build
e902095
@martin-g
Revert "Trigger the build"
e375497 
This reverts commit e902095.
@martin-g
Yaml formatting to fix the CI workflows
9fada45 
```
Invalid workflow file: .github/workflows/codeql-java-analysis.yml#L77
You have an error in your yaml syntax on line 77
```

```
Invalid workflow file: .github/workflows/test-lang-java.yml#L61
You have an error in your yaml syntax on line 61
```
@martin-g
Use a matrix to build with all supported JDK versions
266373a
@martin-g
Avro 1.13.x will require JDK 17+
3bc2f53 
Jetty 12.x requires JDK 17+
@apupier
Copy link
Author

apupier commented Mar 9, 2026

I do not think that we can use a matrix easily as the minimal Java version to do the compilation is JDK 21 but tests are launched with several JDKs versions. it is launched with different Maven execution directly defined in the pom.xml. Each version si picked from the toolchains.xml whcih is configured by the

apupier
apupier commented Mar 9, 2026
View reviewed changes
@martin-g
Copy link
Member

martin-g commented Mar 9, 2026

I do not think that we can use a matrix easily as the minimal Java version to do the compilation is JDK 21 but tests are launched with several JDKs versions. it is launched with different Maven execution directly defined in the pom.xml. Each version si picked from the toolchains.xml whcih is configured by the

OK!
I'll leave it to you. I haven't touched the Java SDK for a long time and obviously I have forgotten how it works.
Please revert whatever is needed.

@apupier
Copy link
Author

apupier commented Mar 9, 2026

I do not think that we can use a matrix easily as the minimal Java version to do the compilation is JDK 21 but tests are launched with several JDKs versions. it is launched with different Maven execution directly defined in the pom.xml. Each version si picked from the toolchains.xml whcih is configured by the

OK! I'll leave it to you. I haven't touched the Java SDK for a long time and obviously I have forgotten how it works. Please revert whatever is needed.

in fact, there are 2 ways of doing it.
Either set the minimal version to Java 17, use a matrix job and keep a single execution.
Or rely on toolchains. it is a bit more advanced, I think it will save time on Ci and it forces to have test splayed locally with all jdk by default. The downside is that it is more complicated to setup and seems that even committers on the project do not remember it.
So I think I will remove the different executions and reliance on the toolchain. (especially when I see that the jobs are already green now, it is just that we are playing the same tests several times with same JDKs and we cna go a bit faster)

apupier added 3 commits March 9, 2026 14:00
@apupier
AVRO-4191 - Update Java Maven toolchain in Build.MD
cacd414 
Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier
AVRo-4191 - Fix naming of github steps related to java
b62da48 
removed Java 8 and 11

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier
AVRo-4191 - remove JDK 11 from test execution
7c0f033 
as 17.x is the minimal version

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier
Copy link
Author

apupier commented Mar 9, 2026

it is surely possible to save the time mentioned here https://github.com/apache/avro/actions/runs/22854799208/job/66292172522?pr=3685#step:8:839 but to be honest, not sure it is worthy to take the risk to change too many things. The current PR should be enough as a first iteration.

@apupier apupier requested a review from martin-g March 9, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-g martin-g martin-g approved these changes

Assignees

No one assigned

Labels

build Java Pull Requests for Java binding

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apupier @martin-g